Skip to content

Conversation

@declspec-cdecl
Copy link

@declspec-cdecl declspec-cdecl commented Nov 18, 2019

Main problem with early-terminated.drain test with fs 2.x.x is that .onFinalize in takeThroughDrain executed after last Stream.eval(queue.dequeue1). I dont know why. I've not found answer even in fs2 gitter. Maybe it's a bug maybe it's a feature. But I've found workaround. If there is .onFinalize{IO.unit} after usage oftakeThroughDrain then all goes as expected. This can be seen in scastie example. So I've fixed all tests and usages of takeThroughDrain with account of the workaround.

@declspec-cdecl declspec-cdecl changed the title Fs 2.0.1 Fs 2.1.0 and workaround for takeThroughDrain Nov 18, 2019
@declspec-cdecl
Copy link
Author

orig PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants